-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release the Python GIL when running PythonEventProcessor. #18683
Conversation
A new Pull Request was created by @jpivarski (Jim Pivarski) for master. It involves the following packages: FWCore/PythonFramework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
The
.run()
method is blocking, so one might want to put it into a Pythonthreading.Thread
. However, the Python interpreter would still block because of the GIL. This correction releases the GIL so that CMSSW can run while Python is running.Tested on a simple example: observed concurrent execution and no segmentation faults.