Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Overlap Between EREG and ETCA #18735

Merged
merged 1 commit into from
May 15, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented May 15, 2017

  • Remove 6.1 cm overlap between EREG and ETCA in Phase 2 scenarios

@kpedro88 - FYI

Before and after snapshots:
screenshot 2017-05-15 12 20 50
screenshot 2017-05-15 12 36 38

@ianna
Copy link
Contributor Author

ianna commented May 15, 2017

please test

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone May 15, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19822/console Started: 2017/05/15 12:44

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/EcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented May 15, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18735/19822/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9999 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830696
  • DQMHistoTests: Total failures: 43783
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1786733
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@kpedro88
Copy link
Contributor

+1
fluctuations in many quantities as expected from geometry change (-> random number change), nothing that looks systematically bad
@ianna should this be backported to 91X?

@ianna
Copy link
Contributor Author

ianna commented May 15, 2017

@kpedro88 - yes, if 91x is used for 2023 MC

@kpedro88
Copy link
Contributor

910 will be the next TDR production release, so please backport it

@ianna
Copy link
Contributor Author

ianna commented May 15, 2017

ok, will do it

@ianna
Copy link
Contributor Author

ianna commented May 15, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2bdd8b2 into cms-sw:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants