Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powheg-bb4l FSR veto #18756

Merged
merged 3 commits into from Jun 6, 2017
Merged

Powheg-bb4l FSR veto #18756

merged 3 commits into from Jun 6, 2017

Conversation

mseidel42
Copy link
Contributor

FSR emission veto for Powheg-bb4l by Tomas Jezo

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19879/console Started: 2017/05/16 20:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18756/19879/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 842166
  • DQMHistoTests: Total failures: 3924
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 837774
  • DQMHistoTests: Total skipped: 468
  • DQMHistoTests: Total Missing objects: 0
  • Checked 51 log files, 14 edm output root files, 13 DQM output files

@perrozzi
Copy link
Contributor

@intrepid42 can this be approved as it is? is there also a PR to master?

@mseidel42
Copy link
Contributor Author

@perrozzi Yes, this should be ok as it is. PowhegHooksBB4L.h is nearly unaltered from the Powheg/b_bbar_4l repository, just added the veto counter.

Will do the PR for master later.

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@mseidel42 mseidel42 mentioned this pull request May 19, 2017
@davidlange6
Copy link
Contributor

what was the master PR for this?

@mseidel42
Copy link
Contributor Author

#18856

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d647e64 into cms-sw:CMSSW_7_1_X Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants