Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

92x cleanup of printouts #18758

Merged
merged 5 commits into from
May 17, 2017
Merged

92x cleanup of printouts #18758

merged 5 commits into from
May 17, 2017

Conversation

davidlange6
Copy link
Contributor

and in addition finalize (at least for the workflow I looked at) a long pending, unfinished, migration in L1T.

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone May 16, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Configuration/StandardSequences
DQM/L1TMonitor
EventFilter/L1TXRawToDigi
L1Trigger/Configuration
L1Trigger/L1TCalorimeter
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
PhysicsTools/PatAlgos
PhysicsTools/SelectorUtils

@perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @franzoni, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @gouskos, @felicepantaleo, @rappoccio, @Martin-Grunewald, @thomreis, @ahinzmann, @mmarionncern, @kreczko, @imarches, @makortel, @acaudron, @jdolen, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @dgulhan, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19863/console Started: 2017/05/16 11:41

@cmsbuild
Copy link
Contributor

-1

Tested at: 011fac9

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d0a05d8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19863/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19863/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19863/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log
1306.0 step2 
runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
1330.0 step2 
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
25202.0 step2 
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
10042.0 step2 
runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log
10024.0 step2 
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log
10824.0 step2 
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log
21234.0 step2 
runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log
23234.0 step2 
runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8.log
24434.0 step2 
runTheMatrix-results/24434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D12_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D12+RecoFullGlobal_2023D12+HARVESTFullGlobal_2023D12/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D12_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D12+RecoFullGlobal_2023D12+HARVESTFullGlobal_2023D12.log
26634.0 step2 
runTheMatrix-results/26634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D15_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D15+RecoFullGlobal_2023D15+HARVESTFullGlobal_2023D15/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D15_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D15+RecoFullGlobal_2023D15+HARVESTFullGlobal_2023D15.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d0a05d8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19863/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19863/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Pull request #18758 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @franzoni, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19876/console Started: 2017/05/16 20:30

@cmsbuild
Copy link
Contributor

+1
Tested at: 8041c02
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19876/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19876/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1678 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833858
  • DQMHistoTests: Total failures: 26464
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1807213
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #18758 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @franzoni, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19907/console Started: 2017/05/17 09:54

@cmsbuild
Copy link
Contributor

-1

Tested at: fa19da6

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fa19da6
1b9c170
415b829
73e8e17
fa947b6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19907/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19907/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19907/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fa19da6
1b9c170
415b829
73e8e17
fa947b6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19907/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19907/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18758/19907/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1690 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833867
  • DQMHistoTests: Total failures: 43304
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1790383
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6 davidlange6 merged commit 99c4a15 into cms-sw:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available dqm-pending l1-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-rejected
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlange6 @cmsbuild