Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Candidate.h/LeafCandidate.h includes to CandidateWithRef.h. #18763

Merged

Conversation

Teemperor
Copy link
Contributor

We inherit from LeafCandidate in CandidateWithRef and we use Candidate
in the overlap function, so we need those includes here.

We inherit from LeafCandidate in CandidateWithRef and we use Candidate
in the overlap function, so we need those includes here.
@Teemperor
Copy link
Contributor Author

This is part of the work going on for the issue #15248.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

DataFormats/Candidate

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 17, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19941/console Started: 2017/05/17 19:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18763/19941/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3368 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833867
  • DQMHistoTests: Total failures: 34315
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799372
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 18, 2017

+1

for #18763 b9c3d77

  • technical
  • jenkins tests pass

@davidlange6 davidlange6 merged commit b03f8e0 into cms-sw:master May 18, 2017
@Teemperor Teemperor deleted the MissingIncludeCandidateWithRef.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the MissingIncludeCandidateWithRef.h branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants