-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing includes to GeneratorInterface/Pythia8Interface. #18792
Add missing includes to GeneratorInterface/Pythia8Interface. #18792
Conversation
Those headers were missing an include to UserHook which they're inheriting from. ResonanceDecayFilterHook is also using the Pythia8::Event class, so we also add the missing include to the Event.h header.
Part of the work to solve the issue #15248 |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: GeneratorInterface/Pythia8Interface @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Those headers were missing an include to UserHook which they're
inheriting from. ResonanceDecayFilterHook is also using
the Pythia8::Event class, so we also add the missing include
to the Event.h header.