Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ALCARECOMuAlGlobalCosmics_cff.py #18812

Conversation

trtomei
Copy link
Contributor

@trtomei trtomei commented May 17, 2017

This one-line PR fixes the crashes in workflows 7.2, 7.3, 7.4, as seen in PR #18753 . We tested and checked that this allows the workflows to run into completion, at the expense of making the AlCaReco and the eventSetupPathsKey having different names.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @trtomei (Thiago Tomei) for master.

It involves the following packages:

Alignment/CommonAlignmentProducer

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19937/console Started: 2017/05/17 18:11

@mmusich
Copy link
Contributor

mmusich commented May 17, 2017

@trtomei, minor point, but given the premises of #18753 shouldn't the right fix be the other way around, i.e. change the AlCaRecoTriggerBitsRcd tag in Global Tag? (what you did here, probably quicker)

@trtomei
Copy link
Contributor Author

trtomei commented May 17, 2017

@mmusich Yes, it should... but at this point we make a (small) sacrifice for the greater good.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6 davidlange6 merged commit 7f19882 into cms-sw:master May 17, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18812/19937/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1616 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833867
  • DQMHistoTests: Total failures: 38767
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1794920
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants