Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcc producer phase1 rebase 92 x #18813

Merged
merged 16 commits into from
May 18, 2017

Conversation

capalmer85
Copy link
Contributor

Rebase to CMSSW_9_2_X #18233

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @capalmer85 for master.

It involves the following packages:

Calibration/LumiAlCaRecoProducers
Configuration/EventContent
Configuration/StandardSequences
DataFormats/Luminosity

@perrotta, @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 17, 2017

@cmsbuild please test

I'm not really sure why a new PR was necessary if instead #18233 could have been updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19947/console Started: 2017/05/17 20:47

@capalmer85
Copy link
Contributor Author

@slava77 Sam is not available today to do the rebasing. It seemed easier for me to do and then be the owner of the PR.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18813/19947/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833935
  • DQMHistoTests: Total failures: 47615
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1786140
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 18, 2017

+1

for #18813 84db1c8

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bf8ea22 into cms-sw:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants