Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: Small memory footprint reduction for the channels mapping handler #18815

Merged
merged 1 commit into from
May 29, 2017

Conversation

forthommel
Copy link
Contributor

@forthommel forthommel commented May 17, 2017

Forward-port of a single commit to keep in sync with the review of the 8_0_X branch of #18734 (#18732).

Save twice an allocation of shared pointers using the make_shared statement

runTheMatrix.py yielded 17 17 16 14 7 1 1 1 tests passed, 1 0 0 0 0 0 0 0 failed (usual DAS failure of 4.22)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

CondFormats/CTPPSReadoutObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link

please test

@ghellwig
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19956/console Started: 2017/05/18 09:26

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18815/19956/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1715 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833935
  • DQMHistoTests: Total failures: 38669
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1795086
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

hi @forthommel - please change the title to be descriptive of the changes for the release notes - thanks

@forthommel forthommel changed the title CTPPS: Forward-port of last commit of #18732 CTPPS: Small memory footprint reduction for the channels mapping handler May 19, 2017
@davidlange6 davidlange6 merged commit c7aa19a into cms-sw:master May 29, 2017
@forthommel forthommel deleted the ctpps-runranges_patch2-9_2_X branch May 29, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants