fillDescriptions fix for E/gamma Pixel Matching Modules #18819
Conversation
|
A new Pull Request was created by @Sam-Harper for master. It involves the following packages: RecoEgamma/EgammaElectronAlgos @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test @Sam-Harper |
|
The tests are being triggered in jenkins. |
| defaults.addParameter<double>("dRZMaxLowEtThres",0.09); | ||
| defaults.addParameter<std::vector<double> >("dRZMaxLowEtEtaBins",std::vector<double>{1.,1.5}); | ||
| defaults.addParameter<std::vector<double> >("dRZMaxLowEt",std::vector<double>{0.09,0.09,0.09}); | ||
| desc.addVPSet("matchingCuts",cutsDesc,std::vector<edm::ParameterSet>{defaults,defaults,defaults}); |
There was a problem hiding this comment.
There are three hits. Realizing now I should have made the first one different but it doesnt matter too much, one can always reset the cuts in confdb. So the default values are not perfectly sensible, if its a problem I can change it.
There was a problem hiding this comment.
As you prefer.
I'm fine either way.
|
@davidlange6 please pick this up for 9.2.0 (assuming it passes all tests) |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@slava77 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
Dear All,
With 9_1_0 now parsed in confdb, I have discovered that I set my fillDescriptions incorrectly for two modules. I regret and appologise for this unnecessary work I have caused you all during this busy time.
Specifically I was missing:
EgammaHLTFilteredSuperClusterProducer.cuts
ElectronNHitSeedProducer.superClusters
I have updated my module configs so confdb can properly parse them. At the same time I set them to proper sensible defaults.
Again my deepest appologises for this oversight.