Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed statics in SiStripDetInfoFileReader #1882

Merged
merged 1 commit into from Dec 19, 2013
Merged

Fixed statics in SiStripDetInfoFileReader #1882

merged 1 commit into from Dec 19, 2013

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer was complaining about two file local statics in SiStripDetInfoFileReader. One I made into a stack variable which probably makes the routine faster and the other I made const.

@Dr15Jones
Fixed statics in SiStripDetInfoFileReader
9295c41 
The static analyzer was complaining about two file local statics in SiStripDetInfoFileReader. One I made into a stack variable which probably makes the routine faster and the other I made const.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Fixed statics in SiStripDetInfoFileReader

It involves the following packages:

CalibTracker/SiStripCommon

@demattia, @cmsbuild, @nclopezo, @rcastello can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@rcastello
Copy link

+1
(if jenkins doesn't complain..)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1882/1854/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 19, 2013
@ktf
Merge pull request #1882 from Dr15Jones/fixStaticsInSiStripDetInfoFil…
9d3c5be 
…eReader

Multithreading fixes -- Fixed statics in SiStripDetInfoFileReader
@ktf ktf merged commit 9d3c5be into cms-sw:CMSSW_7_0_X Dec 19, 2013
@Dr15Jones Dr15Jones deleted the fixStaticsInSiStripDetInfoFileReader branch December 19, 2013 17:12
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
@aledegano
Merge pull request cms-sw#1882 from degano/frontier_76XStable
1abe44e 
Update frontier client to 2.8.13 and pacparser to 1.3.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @rcastello @ktf