new HLT objects monitor code #18879

mtosi · 2017-05-22T11:11:34Z

this new code should replace the older version
https://github.com/mtosi/cmssw/blob/c11bf30f20eea09807dc5c69b1ba87b0fd56ae1d/DQM/HLTEvF/plugins/HLTObjectMonitor.cc

I would suggest to leave the old code running at the begging (~few weeks),
because of back compatibility which allows to compare w/ last year plots in case of need

NB: the list of paths and corresponding module names have to be updated as soon as we have the new HLT menu avaialble

cmsbuild · 2017-05-22T11:11:55Z

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

DQM/HLTEvF
DQMOffline/Trigger

@cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

silviodonato · 2017-05-22T11:13:30Z

please test

cmsbuild · 2017-05-22T11:13:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20018/console Started: 2017/05/22 13:14

cmsbuild · 2017-05-22T11:16:14Z

Pull request #18879 was updated. @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please check and sign again.

silviodonato · 2017-05-22T11:16:21Z

please abort

cmsbuild · 2017-05-22T13:06:04Z

+1
Tested at: 781294e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18879/20018/summary.html

cmsbuild · 2017-05-22T13:06:08Z

Comparison job queued.

cmsbuild · 2017-05-22T16:12:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18879/20018/summary.html

Comparison Summary:

You potentially added 941 lines to the logs
Reco comparison results: 1730 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1832956
DQMHistoTests: Total failures: 57752
DQMHistoTests: Total nulls: 75
DQMHistoTests: Total successes: 1774949
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

mtosi · 2017-06-07T18:48:49Z

yes your 2 suggestions are what i had in mind since last autumn...

…

On 7 Jun 2017, at 18:13, Andrea Bocci ***@***.***> wrote: IIUC, the plots cannot distinguish between a missing path a path present in the menu accepting 0 events I agree that long term we need a more flexible solution. Two possibilities are adding a "tag" in the Path's description in the HLT menu itself (easy to maintain, but technically complicated to implement) moving the list of paths to an AlCa-like tag (easy to implement but more complicated to maintain and keep in sync with the menu) .A — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Martin-Grunewald · 2017-06-08T07:29:42Z

Hmm, so is there anything else still to be done for this PR?

davidlange6 · 2017-06-08T08:39:21Z

please test

cmsbuild · 2017-06-08T08:39:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20416/console Started: 2017/06/08 10:40

cmsbuild · 2017-06-08T10:23:53Z

+1
Tested at: a8e4fa6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18879/20416/summary.html

cmsbuild · 2017-06-08T10:23:56Z

Comparison job queued.

cmsbuild · 2017-06-08T12:43:56Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18879/20416/summary.html

Comparison Summary:

You potentially added 17 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1856821
DQMHistoTests: Total failures: 17867
DQMHistoTests: Total nulls: 220
DQMHistoTests: Total successes: 1838561
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-06-08T13:17:56Z

ok, @mtosi - i think the only outstanding issue is all the copy and paste of PSets. whats the timescale on which you can have that cleaned up?

mtosi · 2017-06-08T13:28:41Z

i'm sorry for this, but could we go w/ this PR as it is now and then i'll make a new PR w/ this fix ?

…

On 8 Jun 2017, at 15:17, David Lange ***@***.***> wrote: ok, @mtosi - i think the only outstanding issue is all the copy and paste of PSets. whats the timescale on which you can have that cleaned up? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

davidlange6 · 2017-06-08T13:38:45Z

is what i was thinking - but lets agree on a timescale..

mtosi · 2017-06-08T14:43:10Z

next week ?

…

On 8 Jun 2017, at 15:38, David Lange ***@***.***> wrote: is what i was thinking - but lets agree on a timescale.. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

davidlange6 · 2017-06-08T14:48:11Z

+1

…

On Jun 8, 2017, at 4:43 PM, mia tosi ***@***.***> wrote: next week ? > On 8 Jun 2017, at 15:38, David Lange ***@***.***> wrote: > > is what i was thinking - but lets agree on a timescale.. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

davidlange6 · 2017-06-08T14:48:40Z

great thanks!

…

On Jun 8, 2017, at 4:43 PM, mia tosi ***@***.***> wrote: next week ? > On 8 Jun 2017, at 15:38, David Lange ***@***.***> wrote: > > is what i was thinking - but lets agree on a timescale.. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mtosi · 2017-06-08T15:14:39Z

thanks ! On Thu, Jun 8, 2017 at 4:48 PM, David Lange <notifications@github.com> wrote:

…

+1 > On Jun 8, 2017, at 4:43 PM, mia tosi ***@***.***> wrote: > > next week ? > > > On 8 Jun 2017, at 15:38, David Lange ***@***.***> wrote: > > > > is what i was thinking - but lets agree on a timescale.. > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub, or mute the thread. > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18879 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt585FF6ZXybCDCatt-zLJiSqsoXeYQks5sCAmygaJpZM4NiNhd> .

silviodonato · 2017-06-09T14:11:00Z

Testing the HLT menu in CMSSW_9_2_2 I found an error due to this PR.
You can reproduce the crash in this way:

cmsrel CMSSW_9_2_1
cd CMSSW_9_2_1/src
cmsenv
git cms-merge-topic 18879
cp /afs/cern.ch/user/s/sdonato/AFSwork/public/bugDQM/RelVal_DigiL1RawHLT_GRun_MC.root .

cmsDriver.py RelVal --step=RAW2DIGI,L1Reco,RECO,EI,PAT,VALIDATION,DQM --conditions=auto:run2_mc_GRun --filein=file:RelVal_DigiL1RawHLT_GRun_MC.root --custom_conditions= --fileout=RelVal_RECO_GRun_MC.root --number=100 --mc --no_exec --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO --eventcontent=RECOSIM,MINIAODSIM,DQM --customise=HLTrigger/Configuration/CustomConfigs.Base --era=Run2_2017 --customise= --scenario=pp --python_filename=RelVal_RECO_GRun_MC.py --processName=RECO --runUnscheduled

cmsRun RelVal_RECO_GRun_MC.py >& logTest1 

scram b -j8

cmsRun RelVal_RECO_GRun_MC.py >& logTest2

logTest2 contains the following error:
cmsRun: /build/cmsbld/auto-builds/CMSSW_9_2_1-slc7_amd64_gcc530/build/CMSSW_9_2_1-build/tmp/BUILDROOT/302421ec588ad9bebd9cb68c9a42c6a9/opt/cmssw/slc7_amd64_gcc530/cms/cmssw/CMSSW_9_2_1/src/DQMServices/Core/src/DQMStore.cc:817: MonitorElement* DQMStore::book(const string&, const string&, const char*, int, HISTO*, COLLATE) [with HISTO = TH1F; COLLATE = void (*)(MonitorElement*, TH1F*, unsigned int); std::string = std::basic_string<char>]: Assertion name.find('/') == std::string::npos' failed.`

while logTest1 is fine.

This error was not catch by jenkins test because we have a fake GRun menu in the current release.

RelVal_DigiL1RawHLT_GRun_MC.root was generated by
cmsDriver.py RelVal --step=DIGI:pdigi_valid,L1,DIGI2RAW,HLT:GRun --conditions=auto:run2_mc_GRun --filein=root://eoscms.cern.ch//eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/GEN-SIM/CMSSW_9_phase1/14F749AC-8AFE-E611-9821-0CC47A78A4A0.root --custom_conditions= --fileout=RelVal_DigiL1RawHLT_GRun_MC.root --number=100 --mc --no_exec --datatier GEN-SIM-DIGI-RAW-HLT --eventcontent=FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era=Run2_2017 --customise= --scenario=pp --python_filename=RelVal_DigiL1RawHLT_GRun_MC.py --processName=HLT
using a realistic GRun menu (see https://github.com/cms-tsg-storm/cmssw/tree/HLT_2017_V1p1).

mtosi · 2017-06-09T14:36:13Z

I think I found the issue ... sorry !!!!!!!!!
I'm testing the patch now
and come back w/ a PR for fixing this issue

add new HLT object monitor code

c11bf30

cmsbuild added this to the CMSSW_9_2_X milestone May 22, 2017

cmsbuild added comparison-pending dqm-pending hlt-pending orp-pending pending-signatures tests-pending labels May 22, 2017

cmsbuild added tests-started and removed tests-pending labels May 22, 2017

switch OFF debug mode

781294e

cmsbuild added tests-pending and removed tests-started labels May 22, 2017

cmsbuild added tests-approved and removed tests-pending labels May 22, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 22, 2017

update EGM HLT objects (thank to sam)

a864fc4

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels May 23, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jun 8, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 8, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 8, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 8, 2017

cmsbuild added orp-approved and removed orp-pending labels Jun 8, 2017

cmsbuild merged commit 6bec4f7 into cms-sw:master Jun 8, 2017

mtosi mentioned this pull request Jun 9, 2017

bug fix for HLT DQM #19171

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new HLT objects monitor code #18879

new HLT objects monitor code #18879

mtosi commented May 22, 2017

cmsbuild commented May 22, 2017

silviodonato commented May 22, 2017

cmsbuild commented May 22, 2017 •

edited

Loading

cmsbuild commented May 22, 2017

silviodonato commented May 22, 2017

cmsbuild commented May 22, 2017

cmsbuild commented May 22, 2017

cmsbuild commented May 22, 2017

mtosi commented Jun 7, 2017 via email

Martin-Grunewald commented Jun 8, 2017

davidlange6 commented Jun 8, 2017

cmsbuild commented Jun 8, 2017 •

edited

Loading

cmsbuild commented Jun 8, 2017

cmsbuild commented Jun 8, 2017

cmsbuild commented Jun 8, 2017

davidlange6 commented Jun 8, 2017

mtosi commented Jun 8, 2017 via email

davidlange6 commented Jun 8, 2017

mtosi commented Jun 8, 2017 via email

davidlange6 commented Jun 8, 2017 via email

davidlange6 commented Jun 8, 2017 via email

mtosi commented Jun 8, 2017 via email

silviodonato commented Jun 9, 2017

mtosi commented Jun 9, 2017

new HLT objects monitor code #18879

new HLT objects monitor code #18879

Conversation

mtosi commented May 22, 2017

cmsbuild commented May 22, 2017

silviodonato commented May 22, 2017

cmsbuild commented May 22, 2017 • edited Loading

cmsbuild commented May 22, 2017

silviodonato commented May 22, 2017

cmsbuild commented May 22, 2017

cmsbuild commented May 22, 2017

cmsbuild commented May 22, 2017

mtosi commented Jun 7, 2017 via email

Martin-Grunewald commented Jun 8, 2017

davidlange6 commented Jun 8, 2017

cmsbuild commented Jun 8, 2017 • edited Loading

cmsbuild commented Jun 8, 2017

cmsbuild commented Jun 8, 2017

cmsbuild commented Jun 8, 2017

davidlange6 commented Jun 8, 2017

mtosi commented Jun 8, 2017 via email

davidlange6 commented Jun 8, 2017

mtosi commented Jun 8, 2017 via email

davidlange6 commented Jun 8, 2017 via email

davidlange6 commented Jun 8, 2017 via email

mtosi commented Jun 8, 2017 via email

silviodonato commented Jun 9, 2017

mtosi commented Jun 9, 2017

cmsbuild commented May 22, 2017 •

edited

Loading

cmsbuild commented Jun 8, 2017 •

edited

Loading