Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing include for <utility> to collectTupleNames.hh #18886

Merged
merged 1 commit into from
May 23, 2017

Conversation

Teemperor
Copy link
Contributor

This is needed because we call std::get in this header which is
provided by the utility header.

This patch also moves the vector and string includes behind the
cassert include to bring them in alphabetical order.

This is needed because we call std::get in this header which is
provided by the utility header.

This patch also moves the vector and string includes behind the
cassert include to bring them in alphabetical order.
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone May 22, 2017
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding issue #15248

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

Alignment/Geners

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link

please test

@ghellwig
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20027/console Started: 2017/05/22 17:06

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18886/20027/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1773 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833024
  • DQMHistoTests: Total failures: 24342
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1808502
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b40b719 into cms-sw:master May 23, 2017
@Teemperor Teemperor deleted the collectTupleNames.hh branch December 19, 2017 08:47
@Teemperor Teemperor restored the collectTupleNames.hh branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants