Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LHERunInfoProduct duplication (backport) #18954

Merged
merged 7 commits into from
Jun 14, 2017

Conversation

perrozzi
Copy link
Contributor

backport of #18846

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrozzi for CMSSW_7_1_X.

It involves the following packages:

SimDataFormats/GeneratorProducts

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrozzi
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20163/console Started: 2017/05/29 12:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18954/20163/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 842166
  • DQMHistoTests: Total failures: 3622
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 838076
  • DQMHistoTests: Total skipped: 468
  • DQMHistoTests: Total Missing objects: 0
  • Checked 51 log files, 14 edm output root files, 13 DQM output files

@perrozzi
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@alberto-sanchez
Copy link
Member

@davidlange6 can this be merged?

@davidlange6
Copy link
Contributor

hi @alberto-sanchez - is this one tested in one of the GEN relvals of 9_2_1?

@perrozzi
Copy link
Contributor Author

this is the 71x backport and it has been tested heavily

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7fdc9c2 into cms-sw:CMSSW_7_1_X Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants