Fix memory leak in ConversionLikelihoodCalculator

[Dr15Jones]

Make sure the reader_ is deleted

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @rafaellopesdesa, @lgray this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20158/console Started: 2017/05/29 00:47

[cmsbuild]

+1
Tested at: 6e9c9cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18990/20158/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18990/20158/summary.html

Comparison Summary:

• You potentially added 25 lines to the logs
• Reco comparison results: 1688 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1840389
• DQMHistoTests: Total failures: 9364
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1830845
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[slava77]

On 5/28/17 3:45 PM, Chris Jones wrote: Make sure the reader_ is deleted

this leaks once per job, right?

[Dr15Jones]

It does leak once per job. But we have so many that leak just once that it is very hard to find ones that leak per event or ones that leak at the beginning and could be deleted at the beginning.

[slava77]

On 5/29/17 5:09 AM, Chris Jones wrote: It does leak once per job. But we have so many that leak just once that it is very hard to find ones that leak per event or ones that leak at the beginning and could be deleted at the beginning.

thanks for the clarification. I'm trying to capture if the mem leak fixes in this and other PRs contribute to the memory issues in data processing.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18990 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbnnLPbY5GlVq08hujQDjxxeXxn6_ks5r-rWXgaJpZM4NoyNb>.

[slava77]

+1

for #18990 6e9c9cd

• implemented as described; technical
• jenkins tests pass and comparisons show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1