-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED Digis trend plot fix #19061
FED Digis trend plot fix #19061
Conversation
A new Pull Request was created by @enochnotsocool (Enoch Chen) for master. It involves the following packages: DQM/SiPixelPhase1Common @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Previously the FED trend plot was causing issue with the GUI server, and it was identified that the TProfile object used to produce the plot was too large due to the fine binning being used for the lumisections, with 1 bin for every lumisection and FED.
The fix defines the "Lumiblock" range for filling the histograms, which allows for 1 bin every 10 lumisection instead, greatly reducing the plot size. Due to the way the plots axis are automatically named in the PixelPhase1 framework, this update should be partnered with a DQMGUI update.