Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED Digis trend plot fix #19061

Merged
merged 4 commits into from Jun 7, 2017
Merged

FED Digis trend plot fix #19061

merged 4 commits into from Jun 7, 2017

Conversation

yimuchen
Copy link
Contributor

@yimuchen yimuchen commented Jun 1, 2017

Previously the FED trend plot was causing issue with the GUI server, and it was identified that the TProfile object used to produce the plot was too large due to the fine binning being used for the lumisections, with 1 bin for every lumisection and FED.
The fix defines the "Lumiblock" range for filling the histograms, which allows for 1 bin every 10 lumisection instead, greatly reducing the plot size. Due to the way the plots axis are automatically named in the PixelPhase1 framework, this update should be partnered with a DQMGUI update.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

A new Pull Request was created by @enochnotsocool (Enoch Chen) for master.

It involves the following packages:

DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Digis

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20353/console Started: 2017/06/06 15:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19061/20353/summary.html

Comparison Summary:

  • You potentially added 37 lines to the logs
  • Reco comparison results: 1705 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837639
  • DQMHistoTests: Total failures: 41315
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1796151
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 378ea56 into cms-sw:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants