Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr92 L1T parser compatible utm-0.6.0 and later #19067

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jun 1, 2017

Make L1T parser compatible with latest utm library (0.6.0 and later from Vienna).
The new UTM library is requested as an external to CMSSW in cms-sw/cmsdist#3071.
This PR should be used in conjunction with this new library.

The change in L1T package only affects parsing of overlap-removal algorithms which
now in the new UTM library "conveniently & intelligently" are supported with different names
for the same functions and the same logic.

Conflicts:
	L1Trigger/L1TGlobal/plugins/TriggerMenuParser.cc
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor

mrodozov commented Jun 1, 2017

please test with cms-sw/cmsdist#3072

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

Comparison job queued.

@davidlange6 davidlange6 merged commit e78bf72 into cms-sw:master Jun 1, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19067/20289/summary.html

Comparison Summary:

  • You potentially added 64 lines to the logs
  • Reco comparison results: 3384 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1789385
  • DQMHistoTests: Total failures: 45986
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1743226
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19067/20314/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6486 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1789200
  • DQMHistoTests: Total failures: 45962
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 1743063
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants