Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling tracktrigger sequence for phase2 Tracker (T5) #19131

Merged
merged 2 commits into from Jun 10, 2017

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jun 7, 2017

Greetings
This PR aims to reintroduce the track trigger sequence for the tracker T5 in the WFs taking into account the new rings belonging to this tracker T5.
At the same time , the local python files used for tracker studies (tracker only configs) have been updated with all the latest ingredients of the geometries .
Thanks to @sviret for having done all the work

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

A new Pull Request was created by @boudoul (boudoul) for master.

It involves the following packages:

Configuration/PyReleaseValidation
L1Trigger/TrackTrigger

@kkousour, @kpedro88, @fabozzi, @cmsbuild, @rekovic, @GurpreetSinghChahal, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @makortel, @felicepantaleo, @sviret, @Martin-Grunewald, @ebrondol this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@boudoul
Copy link
Contributor Author

boudoul commented Jun 7, 2017

Just putting here TT clusters and TTstubs maps obtained with 500 muonPt10 events
cluster_rz
stub_rz

@boudoul
Copy link
Contributor Author

boudoul commented Jun 7, 2017

Adding few watchers : @atricomi @delaere

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 7, 2017

please test

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 7, 2017

@boudoul once this test finishes, can you remove 2023D10 from runTheMatrix.py?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20401/console Started: 2017/06/07 15:17

@boudoul
Copy link
Contributor Author

boudoul commented Jun 7, 2017

ah yes good point, will do after the tests , thanks for the reminder

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19131/20401/summary.html

Comparison Summary:

  • You potentially added 165 lines to the logs
  • Reco comparison results: 1720 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1729089
  • DQMHistoTests: Total failures: 27869
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1701061
  • DQMHistoTests: Total skipped: 159
  • DQMHistoTests: Total Missing objects: 0
  • Checked 86 log files, 14 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Pull request #19131 was updated. @kkousour, @kpedro88, @fabozzi, @cmsbuild, @rekovic, @GurpreetSinghChahal, @mulhearn, @davidlange6 can you please check and sign again.

@boudoul
Copy link
Contributor Author

boudoul commented Jun 7, 2017

Hi @kpedro88 , I removed D10 from runTheMatrix.py in my last commit

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20409/console Started: 2017/06/07 20:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19131/20409/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1703 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1674846
  • DQMHistoTests: Total failures: 52677
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1622017
  • DQMHistoTests: Total skipped: 152
  • DQMHistoTests: Total Missing objects: 0
  • Checked 82 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 8, 2017

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c5782ad into cms-sw:master Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants