Commenting unused variables #19143
Commenting unused variables #19143
Conversation
|
A new Pull Request was created by @mrodozov for master. It involves the following packages: DQM/SiPixelPhase1TrackEfficiency @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test
… On Jun 8, 2017, at 2:14 PM, mrodozov ***@***.***> wrote:
Avoids warnings from unused variables
You can view, comment on, or merge this pull request online at:
#19143
Commit Summary
• Commenting unused variables
File Changes
• M DQM/SiPixelPhase1TrackEfficiency/src/SiPixelPhase1TrackEfficiency.cc (7)
• M DQM/SiPixelPhase1TrackResiduals/src/SiPixelPhase1TrackResiduals.cc (6)
Patch Links:
• https://github.com/cms-sw/cmssw/pull/19143.patch
• https://github.com/cms-sw/cmssw/pull/19143.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The tests are being triggered in jenkins. |
|
@davidlange6 did you ask to do this? |
|
yes - recent changes have introduced compilation warnings that we have fixed.
… On Jun 8, 2017, at 2:25 PM, fioriNTU ***@***.***> wrote:
@davidlange6 did you ask to do this?
@mrodozov sorry but I can't track your github username to any DQM developer, could you tell me who you are and why are you editing DQM code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
ok, fine, sorry for the noise ... and thanks |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
Avoids warnings from unused variables