Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting unused variables #19143

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jun 8, 2017

Avoids warnings from unused variables

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

DQM/SiPixelPhase1TrackEfficiency
DQM/SiPixelPhase1TrackResiduals

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 8, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20424/console Started: 2017/06/08 14:25

@fioriNTU
Copy link
Contributor

fioriNTU commented Jun 8, 2017

@davidlange6 did you ask to do this?
@mrodozov sorry but I can't track your github username to any DQM developer, could you tell me who you are and why are you editing DQM code?

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 8, 2017 via email

@fioriNTU
Copy link
Contributor

fioriNTU commented Jun 8, 2017

ok, fine, sorry for the noise ... and thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19143/20424/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1856821
  • DQMHistoTests: Total failures: 32472
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1824176
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6 davidlange6 merged commit 79d2318 into cms-sw:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants