Undo workaround for ROOT6 namespace bug #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X. Undo workaround for ROOT6 namespace bug It involves the following packages: DataFormats/Common @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
@wmtan I assume you also want ROOT6 to be updated? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
|
Yes, ROOT6 should be updated. |
davidlt
added a commit
that referenced
this pull request
Jan 7, 2014
Undo workaround for ROOT6 namespace bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days ago a temporary workaround for a ROOT6 bug was submitted and merged into the CMSSW ROOT6 branch. The ROOT team surprised us by fixing the bug within a day. This pull request removes the workaround.