Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GenXSecAnalyzer #19186

Merged
merged 1 commit into from
Jul 4, 2017
Merged

update GenXSecAnalyzer #19186

merged 1 commit into from
Jul 4, 2017

Conversation

perrozzi
Copy link
Contributor

Add more information like fraction of negative weights and equivalent lumi for 1M events, beautify output.
Error propagation needs to be crosschecked.
Commit has lot of "noise" from tab conversion to spaces, as it looked screwed on my editor, sorry.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrozzi for master.

It involves the following packages:

GeneratorInterface/Core

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrozzi
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20530/console Started: 2017/06/13 15:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19186/20530/summary.html

Comparison Summary:

  • You potentially added 37 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 34139
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783553
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@perrozzi
Copy link
Contributor Author

perrozzi commented Jul 3, 2017

little feedback from others so far but quite extensive testing from my side didn't show any flaw, approving fro GEN side

@perrozzi
Copy link
Contributor Author

perrozzi commented Jul 3, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7775804 into cms-sw:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants