-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update GenXSecAnalyzer #19186
update GenXSecAnalyzer #19186
Conversation
A new Pull Request was created by @perrozzi for master. It involves the following packages: GeneratorInterface/Core @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
little feedback from others so far but quite extensive testing from my side didn't show any flaw, approving fro GEN side |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Add more information like fraction of negative weights and equivalent lumi for 1M events, beautify output.
Error propagation needs to be crosschecked.
Commit has lot of "noise" from tab conversion to spaces, as it looked screwed on my editor, sorry.