Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROOT6 uses std::string, rather than std::basic_string<char> #1922

Merged
merged 1 commit into from
Dec 31, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 24, 2013

ROOT 6 uses std::string for the type name of a string, whereas ROOT5 used std::basic_string. This pull request changes the code in the ROOT6 branch to use the ROOT6 names, and thereby fixes a failing unit test.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

ROOT6 uses std::string, rather than std::basic_string

It involves the following packages:

FWCore/RootAutoLibraryLoader
FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@davidlt
Copy link
Contributor

davidlt commented Dec 25, 2013

Could it be related to the problem (ROOT-5727) that they don't expand typedefs yet? Because std::string is a typedef of std::basic_string IIRC.

@wmtan
Copy link
Contributor Author

wmtan commented Dec 25, 2013

No, it's not related. You are correct that std::string is a typedef. However, the ROOT team has decided that the name used should be std::string. Also, in the unit test that failed, the dictionary used for the class is specified as std::basic_string, so no typedef was used.

@Dr15Jones
Copy link
Contributor

+1

davidlt added a commit that referenced this pull request Dec 31, 2013
ROOT6 uses std::string, rather than std::basic_string<char>
@davidlt davidlt merged commit 08c7457 into cms-sw:CMSSW_7_0_ROOT6_X Dec 31, 2013
@wmtan wmtan deleted the AdaptToRoot6NamingForString branch December 31, 2013 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants