Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include for Event.h to StoreManagerTrait.h #19288

Merged
merged 1 commit into from
Jun 17, 2017

Conversation

Teemperor
Copy link
Contributor

We use Event in this file, so we also need to include its related
header to make this header compile on its own.

We use Event in this file, so we also need to include its related
header to make this header compile on its own.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

CommonTools/UtilAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20648/console Started: 2017/06/16 16:54

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19288/20648/summary.html

Comparison Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803170
  • DQMHistoTests: Total failures: 29554
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1773450
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

+1

for #19288 716147a

  • technical
  • jenkins tests pass

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1f29718 into cms-sw:master Jun 17, 2017
@Teemperor Teemperor deleted the FixIncludesStoreManagerTrait.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the FixIncludesStoreManagerTrait.h branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants