-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix includes to HLTDiMuonGlbTrkFilter.h #19333
Fix includes to HLTDiMuonGlbTrkFilter.h #19333
Conversation
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: HLTrigger/Muon @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
c92681c
to
f962ade
Compare
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
Pull request #19333 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
1 similar comment
Pull request #19333 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
We use reco::MuonCollection in this header, so we also need to include MuonFwd.h to make this file compile on its file.
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
+1 |
Comparison is ready Comparison Summary:
|
We use reco::MuonCollection in this header, so we also need to
include MuonFwd.h to make this file compile on its file.