Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-alca82 Change output format for MinBias AlCaReco jobs #19524

Merged
merged 4 commits into from
Jul 26, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 3, 2017

Remove the Digi collection and add Raw and Trigger information

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 3, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21095/console Started: 2017/07/03 16:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Pull request #19524 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 3, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21099/console Started: 2017/07/03 17:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19524/21099/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756063
  • DQMHistoTests: Total failures: 15042
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1740855
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

'keep *_hltTriggerSummaryAOD_*_*',
'keep *_TriggerResults_*_*',
'keep FEDRawDataCollection_rawDataCollector_*_*',
'keep FEDRawDataCollection_source_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda
how much increase in size of event content and eventually dataset we expect by keeping all this information?

@franzoni
Copy link

We have a back up solution to bring back the data volume at the same level as previous time

Can you elaborate what such "solution" ?
The size of the relevant 2x ALCARECO for 2017B is (see below) is 1.2 TB, hence not negligible. If
we need a factor x2 we need to be convinced it's essential...

/HcalNZS/Run2017B-HcalCalMinBias-PromptReco-v1/ALCARECO

/HcalNZS/Run2017B-HcalCalMinBias-PromptReco-v2/ALCARECO

@cmsbuild
Copy link
Contributor

Pull request #19524 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21715/console Started: 2017/07/24 18:16

@bsunanda
Copy link
Contributor Author

The old Data Format used to require 0.21 MB per event and the currently proposed one also needs similar amount (a bit less but not significantly lower). So the overall space requirement will be similar.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19524/21715/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2355459
  • DQMHistoTests: Total failures: 29950
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2325343
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@bsunanda
Copy link
Contributor Author

@franzoni Do you have further doubts for this PR?

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 74e2674 into cms-sw:master Jul 26, 2017
cmsbuild added a commit that referenced this pull request Aug 1, 2017
Run2-alca86 Backport corrections to Minimum bias and pedestal o/p commands (#19524)
@bsunanda bsunanda deleted the Run2-alca82 branch August 8, 2017 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants