-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in ExternalLHEProducer in case of earler exception #19549
Fix crash in ExternalLHEProducer in case of earler exception #19549
Conversation
If ExternalLHEProducer throws an exception in begin run, the code will no longer crash when the module is called in end run.
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/LHEInterface @efeyazgan, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
This should avoid the seg-faults seen in the IB RelVals for the cases where the external scripts fail to run. (The jobs will still fail, but now they should fail gracefully.) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
If ExternalLHEProducer throws an exception in begin run, the code will
no longer crash when the module is called in end run.