HcalUnpacker: don't unpack uMNIO digi again as QIE11 digi #19562
Conversation
|
A new Pull Request was created by @DryRun (David Yu) for master. It involves the following packages: EventFilter/HcalRawToDigi @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
DryRun
changed the title
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
@DryRun : could you please provide some/one example of the issue you want to fix? Is it anything that can be seen in the IB tests logs? |
|
There were many reports, here is one of them from Sam Harper on Monday: run 297620, certified as good for HCAL, LS ~60 hltGetConfiguration orcoff:/cdaq/physics/Run2017/2e34/v1.2.3/HLT/V3 --data CMSSW_9_2_3_patch2 Error message: extremely frequent (possibly every event) %MSG-e Invalid Data: HcalRawToDigi:hltHcalDigis 03-Jul-2017 12:40:05 BST <...> |
|
Comparison is ready Comparison Summary:
|
|
Hi Salavat,
Which RelVal_Raw_GRun_DATA.root did you use for that test?
Could you please provide the full recipe to reproduce?
Thank you,
Andrea
Salavat Abdullin <notifications@github.com> ha scritto:
… @perrotta
There were many reports, here is one of them from Sam Harper on Monday:
<...>
run 297620, certified as good for HCAL, LS ~60
setup:
hltGetConfiguration orcoff:/cdaq/physics/Run2017/2e34/v1.2.3/HLT/V3 --data
--full --offline --no-output --globaltag 92X_dataRun2_HLT_v4 --unprescale >
hlt_2e34_v1p2p3_V3.py
CMSSW_9_2_3_patch2
these were the settings it was taken with at P5.
Error message: extremely frequent (possibly every event)
%MSG-e Invalid Data: HcalRawToDigi:hltHcalDigis 03-Jul-2017 12:40:05 BST
Run: 297620 Event: 46996867
QIE11 Collection has 10 samples per digi, raw data has 6!
%MSG
<...>
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#19562 (comment)
|
|
Hi Andrea,
I take the liberty to include Sam Harper (who's e-mail I've quoted above)
in Cc (repsonding by e-mail).
My understanding is that 2017 runs with HCAL Laser calibration included
(e.g. mentioned 297620) they all yield this error when (HCAL) RAW is
unpacked. We did receive this info from various sources.
I believe PR submitter - David Yu (@DryRun) - has tested this fix.
Salavat
…On Wed, 5 Jul 2017, perrotta wrote:
Hi Salavat,
Which RelVal_Raw_GRun_DATA.root did you use for that test?
Could you please provide the full recipe to reproduce?
Thank you,
Andrea
Salavat Abdullin ***@***.***> ha scritto:
> @perrotta
>
> There were many reports, here is one of them from Sam Harper on Monday:
> <...>
>
> run 297620, certified as good for HCAL, LS ~60
> setup:
>
> hltGetConfiguration orcoff:/cdaq/physics/Run2017/2e34/v1.2.3/HLT/V3 --data
> --full --offline --no-output --globaltag 92X_dataRun2_HLT_v4 --unprescale >
> hlt_2e34_v1p2p3_V3.py
>
> CMSSW_9_2_3_patch2
> these were the settings it was taken with at P5.
>
> Error message: extremely frequent (possibly every event)
>
> %MSG-e Invalid Data: HcalRawToDigi:hltHcalDigis 03-Jul-2017 12:40:05 BST
> Run: 297620 Event: 46996867
> QIE11 Collection has 10 samples per digi, raw data has 6!
> %MSG
>
> <...>
>
>
> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> #19562 (comment)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02ssWFNOaK-Y3deCRKcnZcPbEWiLwks5sK7iogaJpZM4OOFdh.gif]
|
|
Here you go: www.cern.ch/sharper/cms/hcalErrMsg/hcalMsg.py a file to run over: so copy both those things in a CMSSW_9_2_4 (or possibly later) area and then cmsRun hcalMsg.py message produced: |
|
Thank you for providing the recipe, Sam!
Salavat
…On Thu, 6 Jul 2017, Sam-Harper wrote:
Here you go:
www.cern.ch/sharper/cms/hcalErrMsg/hcalMsg.py
a file to run over:
www.cern.ch/sharper/cms/hcalErrMsg/DoubleEG_297620_LS60_BABE6E0F-FB5B-E711-9404-02163E014135_200
Events.root
so copy both those things in a CMSSW_9_2_4 (or possibly later) area and then cmsRun hcalMsg.py
message produced:
%MSG-e Invalid Data: HcalRawToDigi:hltHcalDigis 06-Jul-2017 17:08:19 BST Run: 297620 Event:
47187415
QIE11 Collection has 10 samples per digi, raw data has 6!
%MSG
Best,
Sam
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02uP4BPoS7kdONmb51Y9PGMnmlz3nks5sLQcagaJpZM4OOFdh.gif]
|
|
Thank you @Sam-Harper : your config misses the setup_dev_CMSSW_9_2_0_GRun_V52_cff, but with some little gymnastic I got it running, at the end |
|
+1 |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
A continue statement is needed to prevent the uMNIO digi from being unpacked again as a QIE11 digi. This has been causing warnings and early termination of the unpacking, as the uMNIO digi has a different number of samples from the QIE11 digis.