Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EcalIntercalib method to read DBv2 xml files and create sqlite files #19566

Merged
merged 1 commit into from Jul 12, 2017

Conversation

depasse
Copy link
Contributor

@depasse depasse commented Jul 5, 2017

Replaces old method reading DBv1 format files by a new one reading DBv2 format

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor

ggovi commented Jul 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21229/console Started: 2017/07/06 17:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19566/21229/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19566/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1790655
  • DQMHistoTests: Total failures: 14578
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1775911
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Jul 12, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6e81db0 into cms-sw:master Jul 12, 2017
@depasse depasse deleted the EcalJuly2017 branch February 14, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants