Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgcal visualisation fireworks93 x #19579

Merged
merged 2 commits into from Jul 6, 2017

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jul 6, 2017

This PR will add some support into Fireworks to visualise HGCal Multiclusters.
The corresponding backport for 92X is #19578

@malgeri @cseez @felicepantaleo

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

Fireworks/Calo
Fireworks/Candidates

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21207/console Started: 2017/07/06 10:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor

alja commented Jul 6, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e95f10d into cms-sw:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants