Phase2-hgx88 Add a new method to provide layer #'s for each subdetector #19709
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: RecoLocalCalo/HGCalRecAlgos @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@bsunanda maybe it would be a good idea to introduce an enum for these types |
|
or use the ForwardSubdetector enum https://github.com/cms-sw/cmssw/blob/master/DataFormats/ForwardDetId/interface/ForwardSubdetector.h |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-pending
reconstruction-pending
tests-pending
and removed
reconstruction-approved
tests-approved
labels
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison is ready Comparison Summary:
|
|
+1 |
getLayer(const ForwardSubdetector type) returns # of layers for EE (type=HGCEE), FH (type=HGCHEF), BH (type=HGCHEB) and all combined (type=none of the 3 mentioned)