Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tau customization for Phase2 #19788

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Jul 18, 2017

As title says: it is customization for Phase2 upgrade studies at high-PU. It consists of two modifications compared to the Run-2 baseline:

  • fixed strips (pi-zero candidates) a la Run-1 which protect against "fat strips" due to PU photons,
  • tighter dz cut for charged isolation (0.2->0.1) to maintain its efficiency at high-PU.

The modifications do not affect standard workflows, while for Phase2 ones at high-PU a lower number of fake-taus (with e.g. QCD, ttbar samples) esp. at lower-Pt is expected.

Some further details in slides here:

Backport to 92X and 91X will follow shortly.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21562/console Started: 2017/07/18 14:03

@perrotta
Copy link
Contributor

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19788/21562/summary.html

Comparison Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 86 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2025409
  • DQMHistoTests: Total failures: 29355
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1995888
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

+1
changes show up only in reco tau quantities for Phase2 workflows, as expected

@perrotta
Copy link
Contributor

@mbluj : when applying this PR a larger nr of combinatoricRecoTaus is visible (see for example below the event size of those branches in wf 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17)


or, B new, B delta, B delta, % deltaJ, % branch


8757.7 -> 11607.1 2849 28.0 0.32 recoPFTaus_combinatoricRecoTausBoosted__RECO.
1136.3 -> 1091.2 -45 -4.0 -0.01 recoPFTaus_hpsPFTauProducerSansRefs__RECO.
1171.9 -> 1149.5 -22 -1.9 -0.00 recoPFTaus_hpsPFTauProducer__RECO.
24962.2 -> 32230.0 7268 25.4 0.81 recoPFTaus_combinatoricRecoTaus__RECO.


893860 -> 903921 10061 1.1 ALL BRANCHES

This is also visible in the jenkins outputs, e.g.:

image

Is it compatible with the reduced number of fake taus that you claim in the description?

@mbluj
Copy link
Contributor Author

mbluj commented Jul 26, 2017 via email

@perrotta
Copy link
Contributor

Thank you Michal of confirming that the effect of this PR is the one expected.
RelVals run in the tests have indeed FEVTDEBUGHLT event content, which is quite likely not cleaned of the objects not included in the RecoTauTag event content.

@perrotta
Copy link
Contributor

+1
Changes show up only in reco tau quantities for Phase2 workflows, and they are what expected by Tau POG

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit d489da0 into cms-sw:master Jul 26, 2017
@mbluj mbluj deleted the CMSSW_9_3_X_tau-pog_phase2-fixed-strips branch October 10, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants