Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[93X] Improvements to L1 Offline DQM - part 1 (issue #19590) #19795

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

kreczko
Copy link
Contributor

@kreczko kreczko commented Jul 18, 2017

This PR implements the improvements requested in issue #19590 by the L1T team.

@tapperad et all, please have a look

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Jul 18, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21577/console Started: 2017/07/18 16:08

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19795/21577/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2025409
  • DQMHistoTests: Total failures: 15190
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2010053
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@kreczko
Copy link
Contributor Author

kreczko commented Jul 25, 2017

@rekovic @mulhearn please review & sign for L1T

@rekovic
Copy link
Contributor

rekovic commented Aug 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f4c586e into cms-sw:master Aug 9, 2017
@kreczko kreczko deleted the kreczko/issue/19590 branch August 14, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants