Add FEDRawDataCollection to RAWMINIAOD skim event content #19846
Conversation
|
A new Pull Request was created by @kfjack (Kai-Feng Chen) for master. It involves the following packages: Configuration/EventContent @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
…EventContent to avoid the hidden drop * in MicroEventContent.
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
hi @kfjack - seems a clear fix - but any idea how this was missed in the validation last fall (when the event content was updated previously)? |
|
Hi @davidlange6 - not sure. It might be correlated with miniAOD updates. I was looking into the blame history but no clear clue. Sounds like it is better to have a tighter cross check from my side. Do you know how to implement an automatic check for every build? Now the cross check with relval is done by myself from time to time with a private script, and it is not very smart/efficient. |
|
On Jul 26, 2017, at 11:01 AM, Kai-Feng Chen ***@***.***> wrote:
Hi @davidlange6 - not sure. It might be correlated with miniAOD updates. I was looking into the blame history but no clear clue. Sounds like it is better to have a tighter cross check from my side.
nah - it was a bug from day one - it should have been found in the relval checks that I asked for (and got confirmation of) at theme..
Do you know how to implement an automatic check for every build? Now the cross check with relval is done by myself from time to time with a private script, and it is not very smart/efficient.
we have lots of automatic checks. What sort of check do you have in mind?
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ok. So the bug was there at beginning. Apparently this is not good...
The current lazy script in my hand is just listing relval files and check if the corresponding skim files are there, without checking the contents. |
|
On Jul 26, 2017, at 11:24 AM, Kai-Feng Chen ***@***.***> wrote:
Ok. So the bug was there at beginning. Apparently this is not good...
I want to do
• make sure all of the active skims have their output in relval.
• make sure the event content is correct (or the same as before).
neither of these addresses the current issue.. which is when someone makes a new skim that they check its contents in relval and confirm to pdmv that things are working.,.. (pdmv confirmed this skim was validated..)
but ok - for the first one - you can consider writing a unit test that greps through runTheMatrix.py -l all -ne to see what skims are running? If you want to actually check the output of relval production for a prerelease, I guess you'd want to script against das and have that run as part of the validation campaign.
for the second - its not so simple - event contents do change. Eg, people add products to the AOD or RECO. pdmv of course signs whenever someone asks to change a skim event content definition. What sort of check do you want to implement?
… The current lazy script in my hand is just listing relval files and check if the corresponding skim files are there, without checking the contents.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Indeed implementing those checks cannot resolve this current issue (or prevent from it for future updates; the content should be checked by skim users in any case), but better than nothing I think... Anyway for the check one - do you have a recommended starting point? Given I still have ~few working days I can dig a little bit here. Update: just discussed with Francesco on this. We have confirmed that we did not skip any validation checks nor relval tests before changing the content, and got the GL from skim users. But somehow the this was still happening unfortunately. |
|
merge |
Adding FEDRawDataCollection to RAW+MINIAOD event content, which is used in the MuTau skim.