Bug fix pat::TriggerObjectStandAlone #19942

Dr15Jones · 2017-07-27T16:40:24Z

The pat::TriggerObjectStandAlone was directly calling the ParameterSet registry assuming that a
previous call would fill the registry. That assumption was incorrect. Now the class calls the method
EventBase::parameterSet which will do the necessary up dating of the registry behind the scenes.

In order to interact with a TriggerObjectStandAlone one needs a non-const instance. The copy function makes it easier to get a non-const from a const.

The previous code was calling the product registry directly and assumed calling EventBase::triggerNames would always update the registry. That assumption was incorrect. The registry was only updated if the triggerNames PSet was not found in the cache. Calling EventBase::parameterSet does guarantee that the registry is up to date.

cmsbuild · 2017-07-27T16:40:44Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@gpetruc, @gouskos, @cbernet this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2017-07-27T16:40:54Z

please test

cmsbuild · 2017-07-27T16:41:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21837/console Started: 2017/07/27 18:41

Dr15Jones · 2017-07-27T16:42:32Z

This fixes the problem reported here:
https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3546/1/1.html

cmsbuild · 2017-07-27T21:19:10Z

-1

Tested at: 217e542

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5072a68
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21837/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21837/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21837/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5072a68
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21837/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21837/git-merge-result

cmsbuild · 2017-07-27T21:19:13Z

Comparison job queued.

cmsbuild · 2017-07-28T01:28:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21837/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2379966
DQMHistoTests: Total failures: 14663
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2365137
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

perrotta · 2017-07-28T06:17:01Z

The error in the unit test is unrelated:

stat: cannot stat `dqm_empty.root': No such file or directory
read_missing_file_cfg.py ------------------------------------------------------------
27-Jul-2017 19:24:27 CEST Initiating request to open file file:dqm_missing.root
27-Jul-2017 19:24:28 CEST Successfully opened file file:dqm_missing.root
----- Begin Fatal Exception 27-Jul-2017 19:24:28 CEST-----------------------
An exception of category 'FileReadError' occurred while
[0] Calling InputSource::readFile_
[1] Opening DQM Root file
Exception Message:
Input file file:dqm_missing.root appears to be corrupted since it does not have the proper internal structure.
Check to see if the file was closed properly.
----- End Fatal Exception -------------------------------------------------

Dr15Jones · 2017-07-28T11:48:28Z

please test

cmsbuild · 2017-07-28T11:48:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21852/console Started: 2017/07/28 14:04
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21859/console Started: 2017/07/28 15:14

cmsbuild · 2017-07-28T16:13:17Z

-1

Tested at: 217e542

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ee43b2f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21859/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21859/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21859/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34_v2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 17:57:52 2017-date Fri Jul 28 17:36:48 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:2e34_v2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34_v2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34_v2_MC.root --fileout file:RelVal_Raw_2e34_v2_MC_HLT_RECO.root : FAILED - time: date Fri Jul 28 17:57:52 2017-date Fri Jul 28 17:36:48 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 17:48:37 2017-date Fri Jul 28 17:36:51 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Jul 28 17:48:37 2017-date Fri Jul 28 17:36:51 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 17:50:30 2017-date Fri Jul 28 17:36:56 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 17:57:52 2017-date Fri Jul 28 17:36:59 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Jul 28 17:57:52 2017-date Fri Jul 28 17:36:59 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 17:54:25 2017-date Fri Jul 28 17:37:47 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 18:01:14 2017-date Fri Jul 28 17:43:29 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Jul 28 18:01:14 2017-date Fri Jul 28 17:43:29 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 17:54:28 2017-date Fri Jul 28 17:45:25 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 18:02:30 2017-date Fri Jul 28 17:50:35 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 18:06:23 2017-date Fri Jul 28 17:57:59 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Jul 28 18:06:23 2017-date Fri Jul 28 17:57:59 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34_v2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 18:06:50 2017-date Fri Jul 28 18:01:12 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:2e34_v2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34_v2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34_v2_DATA.root --fileout file:RelVal_Raw_2e34_v2_DATA_HLT_RECO.root : FAILED - time: date Fri Jul 28 18:06:50 2017-date Fri Jul 28 18:01:12 2017 s - exit: 21248

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ee43b2f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21859/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21859/git-merge-result

cmsbuild · 2017-07-28T16:13:19Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Dr15Jones · 2017-07-28T16:18:15Z

The failures of the tests are unrelated to this pull request (i.e. they are already present in the IB).
This time through the unit tests passed which means the original failure was an unrelated glitch.

perrotta · 2017-07-28T16:18:50Z

please test
(let try once again: tests should now avoid the latest, broken IB...)

cmsbuild · 2017-07-28T16:19:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21879/console Started: 2017/07/28 18:19

cmsbuild · 2017-07-28T18:16:14Z

+1
Tested at: 217e542
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21879/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
29a96fd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21879/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21879/git-merge-result

cmsbuild · 2017-07-28T18:16:16Z

Comparison job queued.

cmsbuild · 2017-07-28T22:40:56Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19942/21879/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2376534
DQMHistoTests: Total failures: 40244
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2336124
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

slava77 · 2017-07-31T18:00:42Z

+1

for #19942 217e542

changes are in line with the description/resolution of the issue
jenkins tests pass

davidlange6 · 2017-08-01T07:42:59Z

merge

Dr15Jones added 2 commits July 27, 2017 18:34

Added convenience function copy

be4347a

In order to interact with a TriggerObjectStandAlone one needs a non-const instance. The copy function makes it easier to get a non-const from a const.

cmsbuild added this to the CMSSW_9_3_X milestone Jul 27, 2017

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 27, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 27, 2017

cmsbuild added tests-rejected and removed tests-started labels Jul 27, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 28, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Jul 28, 2017

cmsbuild removed the tests-pending label Jul 28, 2017

cmsbuild added the tests-started label Jul 28, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 28, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jul 28, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 28, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 28, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 31, 2017

cmsbuild merged commit 526887f into cms-sw:master Aug 1, 2017

Dr15Jones deleted the bugFixTriggerObjectStandAlone branch August 1, 2017 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fix pat::TriggerObjectStandAlone #19942

Bug fix pat::TriggerObjectStandAlone #19942

Dr15Jones commented Jul 27, 2017

cmsbuild commented Jul 27, 2017

Dr15Jones commented Jul 27, 2017

cmsbuild commented Jul 27, 2017 •

edited

Loading

Dr15Jones commented Jul 27, 2017

cmsbuild commented Jul 27, 2017

cmsbuild commented Jul 27, 2017

cmsbuild commented Jul 28, 2017

perrotta commented Jul 28, 2017

Dr15Jones commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 •

edited

Loading

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

Dr15Jones commented Jul 28, 2017

perrotta commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 •

edited

Loading

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

slava77 commented Jul 31, 2017

davidlange6 commented Aug 1, 2017

Bug fix pat::TriggerObjectStandAlone #19942

Bug fix pat::TriggerObjectStandAlone #19942

Conversation

Dr15Jones commented Jul 27, 2017

cmsbuild commented Jul 27, 2017

Dr15Jones commented Jul 27, 2017

cmsbuild commented Jul 27, 2017 • edited Loading

Dr15Jones commented Jul 27, 2017

cmsbuild commented Jul 27, 2017

cmsbuild commented Jul 27, 2017

cmsbuild commented Jul 28, 2017

perrotta commented Jul 28, 2017

Dr15Jones commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 • edited Loading

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

Dr15Jones commented Jul 28, 2017

perrotta commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 • edited Loading

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

slava77 commented Jul 31, 2017

davidlange6 commented Aug 1, 2017

cmsbuild commented Jul 27, 2017 •

edited

Loading

cmsbuild commented Jul 28, 2017 •

edited

Loading

cmsbuild commented Jul 28, 2017 •

edited

Loading