Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc7 warning fix: increase size to avoid memory override #19957

Merged
merged 1 commit into from
Jul 30, 2017

Conversation

smuzaffar
Copy link
Contributor

this should fix the warning

SimG4CMS/Calo/test/HFPMTHitAnalyzer.cc:72:30: warning: 'void* __builtin_memcpy(void*, const void*, long unsigned int)' writing 11 bytes into a region of size 10 overflows the destination [-Wstringop-overflow=]
      if      (i == 0) sprintf (sub, "(Absorber)");

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-27-2300/SimG4CMS/Calo

this should fix the warning
```
SimG4CMS/Calo/test/HFPMTHitAnalyzer.cc:72:30: warning: 'void* __builtin_memcpy(void*, const void*, long unsigned int)' writing 11 bytes into a region of size 10 overflows the destination [-Wstringop-overflow=]
      if      (i == 0) sprintf (sub, "(Absorber)");
```
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-27-2300/SimG4CMS/Calo
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21871/console Started: 2017/07/28 16:59

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19957/21871/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1386 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2376234
  • DQMHistoTests: Total failures: 37475
  • DQMHistoTests: Total nulls: 301
  • DQMHistoTests: Total successes: 2338292
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@civanch
Copy link
Contributor

civanch commented Jul 29, 2017

+1
there are about 550 différences in HLT comparaison sub-directory for data and MC WFs, this PR is not responsible for such differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 748dae0 into master Jul 30, 2017
@smuzaffar smuzaffar deleted the smuzaffar-patch-1 branch August 9, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants