Fixed StorageAccount token creation #19965
Conversation
The way tokens were assigned values was flawed such that only the values of 0 or 1 were possible and were assigned to multiple names. The problem was the return value of 'tbb::concurrent_unordered_map::insert' was mis-interpreted and the bool value which denotes if the item had already been inserted was used as the token value instead of the unique value assigned.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Utilities/StorageFactory @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@bbockelm this is the danger of |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
please abort |
|
Jenkins tests are aborted. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
The way tokens were assigned values was flawed such that only the values of 0 or 1 were possible and were assigned to multiple names.
The problem was the return value of 'tbb::concurrent_unordered_map::insert' was mis-interpreted and the bool value which denotes if the item had already been inserted was used as the token value instead of the unique value assigned.