Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new beamhlt dqm client #19968

Merged
merged 3 commits into from
Aug 10, 2017
Merged

new beamhlt dqm client #19968

merged 3 commits into from
Aug 10, 2017

Conversation

sikler
Copy link
Contributor

@sikler sikler commented Jul 29, 2017

New beamhlt_dqm_sourceclient-live_cfg.py.

It uses the stream is streamDQMOnlineBeamspot and consumes the objects from
HLT: tracks are hltPFMuonMerging, vertices are hltVerticesPFFilter. Since HLT
provides no digis, only dqmBeamMonitor runs. The client is a much slimmed-down
version of the original beam_dqm_sourceclient-live_cfg.py.

There is a new DQM folder called BeaMonitorHLT, the client outputs folders Fit
and PrimaryVertex.

The client was tested on run several runs for proper functioning and timing
(4-5 per fits at the end of blocks with 10 LSs).

For further info please check:
https://twiki.cern.ch/twiki/bin/view/CMS/OnlineBeamSpot#23_June_2017_check_the_new_DQMOn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sikler (Ferenc Siklér) for CMSSW_9_2_X.

It involves the following packages:

DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@sikler
Copy link
Contributor Author

sikler commented Jul 31, 2017

Marco tells me that BeamFitResultsHLT.txt as filename would work better for lines 63,64,67,69.

@sikler
Copy link
Contributor Author

sikler commented Aug 1, 2017

Broen proposes to choose different names

  • folder: "TrackingBeamspotStream"
  • application name: "trackingbeamspotstream"

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Pull request #19968 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Pull request #19968 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Aug 9, 2017

Please review, in case comment, sign, and eventually deploy at P5.

@vanbesien
Copy link
Contributor

It is already deployed at P5.
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMP5TagCollector

B

@fwyzard
Copy link
Contributor

fwyzard commented Aug 9, 2017

Thanks !
I'll move further comments back on the email thread...

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22158/console Started: 2017/08/09 10:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19968/22158/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 44267
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1747341
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0878de5 into cms-sw:CMSSW_9_2_X Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants