Geometry Clang Check modernize-use-emplace #19975
Conversation
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: Geometry/CSCGeometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@kpedro88 - please, review |
|
@kpedro88 - what about this one? |
| @@ -86,7 +86,7 @@ std::vector<HcalFlexiHardcodeGeometryLoader::HBHOCellParameters> HcalFlexiHardco | |||
| << "]: " << etabins[i].layer[k].first-1 << ":" | |||
| << etabins[i].layer[k].second << std::endl; | |||
| #endif | |||
| result.push_back (HcalFlexiHardcodeGeometryLoader::HBHOCellParameters(iring, depth, etabin.phis[j].first, etabin.phis[j].second, dphi, rmin, rmax, etabin.etaMin, etabin.etaMax)); | |||
| result.emplace_back (HcalFlexiHardcodeGeometryLoader::HBHOCellParameters(iring, depth, etabin.phis[j].first, etabin.phis[j].second, dphi, rmin, rmax, etabin.etaMin, etabin.etaMax)); | |||
There was a problem hiding this comment.
should the constructor be removed here (and for the others in this file and the other loader)?
There was a problem hiding this comment.
IMHO, it's better for readability to keep it - there are way too many parameters in the constructor
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
Geometry part of @davidlange6's PR #19654