Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Utilities/General #19981

Merged
merged 2 commits into from
Aug 2, 2017
Merged

Cleanup Utilities/General #19981

merged 2 commits into from
Aug 2, 2017

Conversation

Dr15Jones
Copy link
Contributor

The only use of own_ptr can easily be replaced with unique_ptr.

@Dr15Jones
Replace own_ptr with std::unique_ptr
f231775 
The only use of own_ptr can easily be replaced with unique_ptr.
@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Jul 31, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Utilities/General

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21916/console Started: 2017/07/31 16:24

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@Dr15Jones
Removed Tokenizer and simplified FileInPath
6e24197 
The Tokenizer class was only used by FileInPath and could be replaced
with one line from boost.
Made some simplifications of FileInPath and brought it more inline
with CMSSW coding conventions.
@cmsbuild
Copy link
Contributor

Pull request #19981 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

Made a few more cleanups in Utilities/General including removing Tokenizer.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21920/console Started: 2017/07/31 17:28
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21942/console Started: 2017/08/01 09:59

@Dr15Jones Dr15Jones changed the title Replace own_ptr with std::unique_ptr Cleanup Utilities/General Jul 31, 2017
@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

+1
Tested at: 6e24197
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19981/21942/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
46f824c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19981/21942/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19981/21942/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19981/21942/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2651091
  • DQMHistoTests: Total failures: 75618
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2575292
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c4a7b2f into cms-sw:master Aug 2, 2017
@Dr15Jones Dr15Jones deleted the remove_own_ptr branch August 2, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.
3 participants
@Dr15Jones @cmsbuild @davidlange6