Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Material Budget Errors #19987

Merged
merged 1 commit into from Aug 1, 2017
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 1, 2017

  • Declare correct type TProfile2D

@ianna
Copy link
Contributor Author

ianna commented Aug 1, 2017

please test

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Aug 1, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21939/console Started: 2017/08/01 07:59
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21941/console Started: 2017/08/01 08:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Validation/Geometry

@civanch, @Dr15Jones, @vazzolini, @kmaeshima, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Aug 1, 2017

@ianna , it is also fixed in #19939

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Aug 1, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Aug 1, 2017

@davidlange6 , I may be wrong but likely due this bug comparison job never finished if SIM is involved. As a result, some PRs are stack, so please, merge this - it is correct and trivial.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1b89497 into cms-sw:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants