SiStrip DQM-popCon classes reorganisation (removing uses of edm::Service) #19988
Conversation
|
A new Pull Request was created by @pieterdavid (Pieter David) for master. It involves the following packages: CondTools/SiStrip @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @ggovi, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
(forgotten yesterday): CC @OlivierBondu @alesaggio @vidalm . The xxxDetId->TrackerTopology migration is tracked at #19398 |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-19988/215 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-19988/215/git-diff.patch In future, you can run |
|
Pull request #19988 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @ggovi, @vanbesien can you please check and sign again. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This is a set of (purely technical) changes that I prepared last year as part of an effort to reduce the number of edm::Service classes in the strip tracker offline software (see https://twiki.cern.ch/twiki/bin/viewauth/CMS/SiStrip_edmServicesToESProducersPopConSourceHandlers), forgot to submit back then, and revived now (rebased after the
boost::lexical_castremoval (on yesterday's 11:00 IB tag), and with a few commits added) because it makes it much easier to port these classes from the subdetector-DetIds to using the TrackerTopology (see https://twiki.cern.ch/twiki/bin/viewauth/CMS/SiStripLocalReco_notesSiStripSubDetIdToTrackerTopologyMigration).This moves quite a bit of code around (I modified the inheritance structure and use of templates, because without the services it looked more sensible to have the most specific code - that used to be in the services - to the most specific classes in the hierarchy), so there is a risk of breaking things, but I don't really know how to properly test these changes (I tried to run the test configs, but at least some of them look outdated/broken)... maybe the DQM can provide some guidance on that? Thanks in advance!