92x L1T uGT fix disagreement fw/emul OOT dcorrelations algorithms

[rekovic]

PR 92x (backport of #19994) needed for data taking.

• fix disagreement fw/emul OOT correlations algorithms (CDC algos in the L1T menu).
  The fix is to have emulator correctly check BX for conditions.

Without this fix, the event are not accepted by L1T CDC algo when fw/emul disagree (large percentage).
Please merge for next data taking release if possible.

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21963/console Started: 2017/08/01 17:06

[cmsbuild]

A new Pull Request was created by @rekovic for CMSSW_9_2_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

• Backported from 93x L1T uGT fix disagreement fw/emul OOT correlations algorithms #19994

[rekovic]

backport of #19994

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Pull request #19993 was updated. @cmsbuild, @rekovic, @mulhearn can you please check and sign again.

[rekovic]

please test

[rekovic]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21979/console Started: 2017/08/01 19:02

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 251f79e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21963/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
79d69df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21963/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21963/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

+1
Tested at: c6f07a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21979/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
86691ac
79d69df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21979/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21979/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21963/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1791781
• DQMHistoTests: Total failures: 15021
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1776594
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19993/21979/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1791781
• DQMHistoTests: Total failures: 29342
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1762273
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[davidlange6]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will be automatically merged.