Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixing workflows that use playback #20024

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

mandrenguyen
Copy link
Contributor

@mandrenguyen mandrenguyen commented Aug 2, 2017

Back in 81X, PR #15436 caused the heavy-ion embedding workflows that use the playback mechanism to stop giving sensible results.
The symptom was that the primary vertex stopped being reconstructed, defaulting instead to the beamspot.
For 80X, we simply reverted the corresponding PR with PR #18528

This PR fixes the issue in the master. This can be seen by running wf 301 and scanning thru the PVs with FWLite as follows:
Events->Scan("recoVertexs_hiSelectedVertex__RECO.obj.position_.fCoordinates.fZ")
With this PR you will see distinct z-vertex values.

@mdhildreth : Can you have a look?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @ebrondol this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22025/console Started: 2017/08/02 19:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison job queued.

@civanch
Copy link
Contributor

civanch commented Aug 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22118/console Started: 2017/08/07 10:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20024/22118/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2643105
  • DQMHistoTests: Total failures: 239
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642685
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 10, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 340d62a into cms-sw:master Aug 11, 2017
mandrenguyen added a commit to mandrenguyen/cmssw that referenced this pull request Sep 27, 2017
@mandrenguyen mandrenguyen deleted the playbackBugFix93X branch October 22, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants