-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mixing workflows that use playback #20024
Conversation
A new Pull Request was created by @mandrenguyen for master. It involves the following packages: SimGeneral/MixingModule @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Back in 81X, PR #15436 caused the heavy-ion embedding workflows that use the playback mechanism to stop giving sensible results.
The symptom was that the primary vertex stopped being reconstructed, defaulting instead to the beamspot.
For 80X, we simply reverted the corresponding PR with PR #18528
This PR fixes the issue in the master. This can be seen by running wf 301 and scanning thru the PVs with FWLite as follows:
Events->Scan("recoVertexs_hiSelectedVertex__RECO.obj.position_.fCoordinates.fZ")
With this PR you will see distinct z-vertex values.
@mdhildreth : Can you have a look?