Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[93X] make cut on number of tracks in Strip Hit Efficiency code configurable #20052

Merged
merged 3 commits into from
Aug 9, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 4, 2017

Update module which is used to ntuplize Hit Efficiency trees, to allow events with > 100 reconstructed tracks in it to enter the computation.
For the time being the cut is set to yield the same trees as before.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripHitEfficiency

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @jlagram, @mmusich, @gbenelli, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22083/console Started: 2017/08/04 10:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20052/22083/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2642897
  • DQMHistoTests: Total failures: 29567
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2613149
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2017

@arunhep @lpernie ping

@arunhep
Copy link
Contributor

arunhep commented Aug 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants