Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-hcx140 Backport PR's #19574 and #20049 which provides two HLT filters (1) for selecting multiple L1 objects; (2) Laser firing in HCAL #20065

Merged
merged 4 commits into from
Aug 22, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 4, 2017

Add two filters (1) for selection on multiple types of L1 objects; (2) Laser fire in HCAL. Back port the two PR's #19574 and #20049

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

A new Pull Request was created by @bsunanda for CMSSW_9_2_X.

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 4, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22104/console Started: 2017/08/04 19:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20065/22104/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 29508
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1762100
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Pull request #20065 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Pull request #20065 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 8, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22140/console Started: 2017/08/08 14:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20065/22140/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 44258
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1747350
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

hi @bsunanda - please change the title of this PR to be descriptive of the changes included. thanks

@davidlange6
Copy link
Contributor

ping

@Martin-Grunewald
Copy link
Contributor

@bsunanda
Sunanda, can you please address the comment above?
Thanks!

@bsunanda bsunanda changed the title Run2-hcx140 Backport PR's #19574 and #20049 for 9_2_X Run2-hcx140 Backport PR's #19574 and #20049 which provides two HLT filters (1) for selecting multiple L1 objects; (2) Laser firing in HCAL Aug 17, 2017
@bsunanda
Copy link
Contributor Author

@Martin-Grunewald @davidlange6 modified title and description

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 44603af into cms-sw:CMSSW_9_2_X Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants