Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating GT for online (v7) and express (v6) #20074

Merged

Conversation

vanbesien
Copy link
Contributor

PR for master (9_3_X)

GT 92X_dataRun2_HLT_v7, to be used for online DQM CMSSW >= 9_2_7

Also fixed some trailing spaces, updated the express GT and added some documentation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

A new Pull Request was created by @vanbesien (Broen van Besien) for master.

It involves the following packages:

DQM/Integration

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@vanbesien
Copy link
Contributor Author

vanbesien commented Aug 7, 2017

Backport in #20075

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Pull request #20074 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@vanbesien
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22134/console Started: 2017/08/08 11:45

@vanbesien
Copy link
Contributor Author

@dmitrijus This is stable and running in production now. Please review and sign and get it merged.
Thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

-1

Tested at: 90753c8

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
947a871
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20074/22134/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20074/22134/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20074/22134/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1330.0 step4

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step4_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
947a871
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20074/22134/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20074/22134/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@vanbesien
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22147/console Started: 2017/08/08 17:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20074/22147/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2646495
  • DQMHistoTests: Total failures: 202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646112
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e16e219 into cms-sw:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants