updates to tau3mu HLT producer #20089

rmanzoni · 2017-08-09T09:12:46Z

back port of #20088

… pt, fix isolation condition logic

cmsbuild · 2017-08-09T09:13:06Z

A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_9_2_X.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2017-08-09T09:39:33Z

please test

cmsbuild · 2017-08-09T09:39:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22164/console Started: 2017/08/09 11:40

cmsbuild · 2017-08-09T09:48:35Z

Pull request #20089 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

cmsbuild · 2017-08-09T09:49:39Z

-1

Tested at: c070b5e

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d9f7765
b8f6f68
18205ff
6fed1f6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22164/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22164/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22164/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/DQMServices/Core/src/DQMEDHarvester.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/DQMServices/Core/src/DQMError.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/DQMServices/Core/src/DQMOldReceiver.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/src/SealModule.cc:49:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/interface/HLTTriMuonIsolation.h: In member function 'virtual void HLTTriMuonIsolation::produce(edm::StreamID, edm::Event&, const edm::EventSetup&) const':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/interface/HLTTriMuonIsolation.h:237:26: error: assignment of member 'HLTTriMuonIsolation::ChAbsIsoCut_' in read-only object
             ChAbsIsoCut_ = EnableAbsIso_ ? ChargedAbsIsoCut_             : std::numeric_limits::infinity();
                          ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/interface/HLTTriMuonIsolation.h:238:26: error: assignment of member 'HLTTriMuonIsolation::ChRelIsoCut_' in read-only object
             ChRelIsoCut_ = EnableRelIso_ ? ChargedRelIsoCut_ * itau.pt() : std::numeric_limits::infinity();
                          ^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/src/HLTMuonL1RegionalFilter.cc 
2 warnings generated.
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/src/SealModule.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/src/HLTMuonL1toL3TkPreFilter.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/src/SealModule.cc:49:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/interface/HLTTriMuonIsolation.h:237:26: error: cannot assign to non-static data member within const member function 'produce'
            ChAbsIsoCut_ = EnableAbsIso_ ? ChargedAbsIsoCut_             : std::numeric_limits::infinity();
            ~~~~~~~~~~~~ ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-08-08-2300/src/HLTrigger/Muon/interface/HLTTriMuonIsolation.h:98:22: note: member function 'HLTTriMuonIsolation::produce' is declared const here
HLTTriMuonIsolation::produce(edm::StreamID sid, edm::Event & iEvent, edm::EventSetup const & iSetup) const
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d9f7765
b8f6f68
18205ff
6fed1f6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22164/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22164/git-merge-result

cmsbuild · 2017-08-09T09:49:42Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

Martin-Grunewald · 2017-08-09T10:30:07Z

please test

cmsbuild · 2017-08-09T10:30:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22166/console Started: 2017/08/09 13:09

cmsbuild · 2017-08-09T12:02:58Z

+1
Tested at: efd1215
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22166/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d9f7765
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22166/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22166/git-merge-result

cmsbuild · 2017-08-09T12:03:01Z

Comparison job queued.

cmsbuild · 2017-08-09T17:48:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20089/22166/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1791842
DQMHistoTests: Total failures: 29440
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1762236
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

Martin-Grunewald · 2017-08-10T12:06:47Z

+1

cmsbuild · 2017-08-10T12:07:03Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-08-22T19:17:39Z

+1

apply selections but isolation at the tau building step, sort taus by…

c070b5e

… pt, fix isolation condition logic

cmsbuild added this to the CMSSW_9_2_X milestone Aug 9, 2017

cmsbuild added comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels Aug 9, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 9, 2017

make produce abide to the promise of being const

efd1215

cmsbuild added tests-pending and removed tests-started labels Aug 9, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 9, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 9, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 9, 2017

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Aug 10, 2017

cmsbuild added orp-approved and removed orp-pending labels Aug 22, 2017

cmsbuild merged commit b6b6668 into cms-sw:CMSSW_9_2_X Aug 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updates to tau3mu HLT producer #20089

updates to tau3mu HLT producer #20089

rmanzoni commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

Martin-Grunewald commented Aug 9, 2017

cmsbuild commented Aug 9, 2017 •

edited

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

Martin-Grunewald commented Aug 9, 2017

cmsbuild commented Aug 9, 2017 •

edited

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

Martin-Grunewald commented Aug 10, 2017

cmsbuild commented Aug 10, 2017

davidlange6 commented Aug 22, 2017

updates to tau3mu HLT producer #20089

updates to tau3mu HLT producer #20089

Conversation

rmanzoni commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

Martin-Grunewald commented Aug 9, 2017

cmsbuild commented Aug 9, 2017 • edited

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

Martin-Grunewald commented Aug 9, 2017

cmsbuild commented Aug 9, 2017 • edited

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

Martin-Grunewald commented Aug 10, 2017

cmsbuild commented Aug 10, 2017

davidlange6 commented Aug 22, 2017

cmsbuild commented Aug 9, 2017 •

edited

cmsbuild commented Aug 9, 2017 •

edited