disable ZS mark and pass for 2017

[deguio]

backport of #20115

[cmsbuild]

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_9_2_X.

It involves the following packages:

RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

• Backported from disable ZS mark and pass for 2017 data. it affects pre-TS1 data only. #20115

[slava77]

if this changes MC and data behavior, this PR can not go in to the production setup.
If settings are needed for special rerecos, they can be passed with a customization.

If this affects only data, perhaps it may still go in, but needs some coordination with a data rereco release

[deguio]

Hi @slava77
this affects data only. there is no ZS emulated in MC.
and yes, we need to make sure that this gets merged in the release that will be used for the early 2017 data rereco.

[slava77]

On 8/10/17 8:17 AM, Federico De Guio wrote: Hi @slava77 <https://github.com/slava77> this affects data only. there is no ZS emulated in MC. and yes, we need to make sure that this gets merged in the release that will be used for the early 2017 data rereco.

What is the size of the effect (perhaps I should wait for response to my q in 93X PR). Was this change discussed in PPD already? I haven't seen anything on this in the general meeting. (the slides there are somewhat suggestive that 9_2_8 released on Aug 5 is to be used for data rereco). Some comments on this in the reco meeting tomorrow would be nice as well.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbs8Gpzx6ErvKWeyCGeGcXUNYnClFks5sWx8XgaJpZM4Ozi5C>.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22209/console Started: 2017/08/11 01:36

[cmsbuild]

+1
Tested at: 9da707b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20117/22209/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1d79e98
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20117/22209/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20117/22209/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20117/22209/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1791774
• DQMHistoTests: Total failures: 14915
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1776693
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[abdoulline]

@slava77
there was quite a live discussion yesterday at PPD on JME results at slide No.7 (comparing middle and right side)
https://indico.cern.ch/event/659010/contributions/2687022/attachments/1506909/2348470/PPD.pdf
JetMET wants to have the right-side result for early 2017 data, which can be provided by this PR.

(Now I see Federico has already provided this info in PR #20115)

[slava77]

On 8/10/17 10:39 PM, Salavat Abdullin wrote: @slava77 <https://github.com/slava77> there was quite a live discussion yesterday at PPD on JME results at slide No.7 (comparing middle and right side) https://indico.cern.ch/event/659010/contributions/2687022/attachments/1506909/2348470/PPD.pdf JetMET wants to have the right-side result for early 2017 data, which is provided by this PR.

I was in the meeting, but the effects of this PR were not clear, specifically the impact on pre and post-TS1. Fede has covered it by now.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbg6ug_Snyx1G2zjW-589QJaeXF0mks5sW-kfgaJpZM4Ozi5C>.

[perrotta]

+1

• Tested in 93X with the corresponding PR disable ZS mark and pass for 2017 data. it affects pre-TS1 data only. #20115, which is identical to this one
• The effect on pre-TS1 data (2017B) is as expected from the description of this PR
• No effect on pst-TS1 (2017C) data, as anticipated
• Jenkins tests report no differences at all, but 2017B data are not tested in 92X
• In particular, there is no effect on MC wfs, as expected: this PR is is therefore suitable for being backported to 92X

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[franzoni]

hello @davidlange6 @perrotta
this PR is necessary for the 2017 rereco being prepared
Is there more feedback or input you need to get it merged in 92 ?
thanks!

@cerminar @deguio @hatakeyamak

[davidlange6]

merge