DetectorDescription Clang readability-avoid-const-params-in-decls

[ianna]

• DetectorDescription part of @davidlange6's clang check readability-avoid-const-params-in-decls #19660

• Other cleanups

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22218/console Started: 2017/08/11 16:07

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core
DetectorDescription/Parser
DetectorDescription/RegressionTest

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20129/57

[cmsbuild]

+1
Tested at: a2db1c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20129/22218/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56f2f72
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20129/22218/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20129/22218/git-merge-result

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20129/22218/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2713569
• DQMHistoTests: Total failures: 239
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2713141
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[davidlange6]

merge