add warnings to L1TGlobalPrescaler (93x) #20144
Conversation
- warn if `l1tPrescales` has the wrong number of elements - warn if the target prescales are lower than the original ones
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: L1Trigger/L1TGlobal @cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
type bugfix |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20144/76 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20144/76/git-diff.patch In future, you can run |
Enabled checks:
boost-use-to-string
cppcoreguidelines-no-malloc
google-build-explicit-make-pair
misc-inefficient-algorithm
misc-string-compare
misc-uniqueptr-reset-release
modernize-avoid-bind
modernize-deprecated-headers
modernize-loop-convert
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-redundant-void-arg
modernize-replace-auto-ptr
modernize-shrink-to-fit
modernize-use-auto
modernize-use-bool-literals
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-nullptr
modernize-use-override
modernize-use-transparent-functors
modernize-use-using
performance-faster-string-find
performance-for-range-copy
performance-implicit-cast-in-loop
performance-inefficient-string-concatenation
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-param
readability-container-size-empty
readability-redundant-string-cstr
readability-static-definition-in-anonymous-namespace
readability-uniqueptr-delete-release
See http://releases.llvm.org/4.0.0/tools/clang/tools/extra/docs/clang-tidy/index.html for details.
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20144/77 |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
|
||
| namespace { | ||
|
|
||
| template <typename T, std::size_t N, typename S> |
There was a problem hiding this comment.
@Dr15Jones @wddgit can you think of any way to support
template <typename T, std::size_t N>
std::array<T, N>
ParameterSet::getParameter<std::array<T, N>>(...)directly in ParameterSet ?
I I understand that it cannot be done as an overload or partial specialisation of ParameterSet::getParameter<T>(...) .
|
Comparison is ready Comparison Summary:
|
|
+1 |
l1tPrescaleshas the wrong number of elements